Show backtrace on allocation failures when possible #148020
Open
+137
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Member
Mark-Simulacrum
approved these changes
Nov 2, 2025
library/std/src/alloc.rs
Outdated
| let mut lock = crate::sys::backtrace::lock(); | ||
|
|
||
| match crate::panic::get_backtrace_style() { | ||
| // SAFETY: we took out a lock just a second ago. |
Member
There was a problem hiding this comment.
It's not clear to me what this safety comment is on - I don't see any unsafe code here?
Member
Author
Member
There was a problem hiding this comment.
BacktraceLock::print is incorrectly marked as safe. It and all callers should be marked unsafe. See 1c8f9bb?w=1#diff-1b221b9e32f6143fdd8a5505c8893377e8e9eb1ff47b988716343c7e70393b1bR40.
Member
Author
There was a problem hiding this comment.
Why is it not safe? The mere fact that you have a BacktraceLock (which you need to call print) means that no other thread can be printing a backtrace, right?
Member
There was a problem hiding this comment.
oh, right. probably the safety comment should just be moved inside that function then?
Member
|
LGTM from the libs side @bors r=Mark-Simulacrum |
Collaborator
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 8, 2025
…acrum Show backtrace on allocation failures when possible And if an allocation while printing the backtrace fails, don't try to print another backtrace as that will never succeed. Split out of rust-lang#147725 to allow landing this independently of a decision whether or not to remove `-Zoom=panic`.
bors
added a commit
that referenced
this pull request
Nov 8, 2025
Rollup of 15 pull requests Successful merges: - #147404 (Fix issue with callsite inline attribute not being applied sometimes.) - #147534 (Implement SIMD funnel shifts in const-eval/Miri) - #147686 (update isolate_highest_one for NonZero<T>) - #148020 (Show backtrace on allocation failures when possible) - #148204 (Modify contributor email entries in .mailmap) - #148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks) - #148555 (Fix rust-by-example spanish translation) - #148556 (Fix suggestion for returning async closures) - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability) - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute) - #148612 (Add note for identifier with attempted hygiene violation) - #148613 (Switch hexagon targets to rust-lld) - #148644 ([bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`) - #148649 (don't completely reset `HeadUsages`) - #148675 (Remove eslint-js from npm dependencies) r? `@ghost` `@rustbot` modify labels: rollup
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 8, 2025
…acrum Show backtrace on allocation failures when possible And if an allocation while printing the backtrace fails, don't try to print another backtrace as that will never succeed. Split out of rust-lang#147725 to allow landing this independently of a decision whether or not to remove `-Zoom=panic`.
bors
added a commit
that referenced
this pull request
Nov 8, 2025
Rollup of 16 pull requests Successful merges: - #147534 (Implement SIMD funnel shifts in const-eval/Miri) - #147686 (update isolate_highest_one for NonZero<T>) - #148020 (Show backtrace on allocation failures when possible) - #148204 (Modify contributor email entries in .mailmap) - #148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks) - #148279 (rustc_builtin_macros: rename bench parameter to avoid collisions with user-defined function names) - #148555 (Fix rust-by-example spanish translation) - #148556 (Fix suggestion for returning async closures) - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability) - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute) - #148612 (Add note for identifier with attempted hygiene violation) - #148613 (Switch hexagon targets to rust-lld) - #148619 (Enable std locking functions on AIX) - #148644 ([bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`) - #148649 (don't completely reset `HeadUsages`) - #148675 (Remove eslint-js from npm dependencies) r? `@ghost` `@rustbot` modify labels: rollup
Member
|
Failed in rollup: #148686 (comment) @bors r- |
bors
added
S-waiting-on-author
Member
Author
|
@bors try jobs=aarch64-msvc-1 |
rust-bors bot
added a commit
that referenced
this pull request
Nov 10, 2025
Show backtrace on allocation failures when possible try-job: aarch64-msvc-1
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 3b69a59 failed: CI. Failed jobs:
|
bjorn3
force-pushed
the
oom_backtrace
branch
from
67a29a5 to
34e0649
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
Added a test ignore for MSVC to match tests/ui/backtrace/backtrace.rs. |
bjorn3
added
S-waiting-on-review
Member
|
r=me with commits squashed |
And if an allocation while printing the backtrace fails, don't try to print another backtrace as that will never succeed.
bjorn3
force-pushed
the
oom_backtrace
branch
from
34e0649 to
4627bff
Compare
Member
Author
|
@bors r=Mark-Simulacrum |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 26, 2025
Show backtrace on allocation failures when possible And if an allocation while printing the backtrace fails, don't try to print another backtrace as that will never succeed. Split out of #147725 to allow landing this independently of a decision whether or not to remove `-Zoom=panic`.
Collaborator
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
The content of the baz function has always been on line 5, not line 15. Presumably it previously accidentally worked as the call in the foo function is on line 15, but now it likely tail calls to bar.
Member
Author
|
Fixed a test that seems like it happened to work by accident before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And if an allocation while printing the backtrace fails, don't try to print another backtrace as that will never succeed.
Split out of #147725 to allow landing this independently of a decision whether or not to remove
-Zoom=panic.